Merged
Conversation
olix0r
requested review from
hawkw and
kleimkuhler
and removed request for
hawkw
hawkw
approved these changes
Jun 13, 2020
Contributor
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
yay! i had a couple non-blocking suggestions.
Contributor
|
Looks like there is still a use of |
olix0r
commented
Jun 13, 2020
Signed-off-by: Eliza Weisman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change drops (unused, defunct) dependencies on the futures-0.1/compat ecosystem.
It does not yet adopt the new runtime due to issues spotted in testing.