re-enable proxy integration tests#561
Merged
hawkw merged 7 commits intomaster-tokio-0.2from Jun 14, 2020
Merged
Conversation
olix0r
approved these changes
Jun 12, 2020
kleimkuhler
approved these changes
Jun 12, 2020
Contributor
kleimkuhler
left a comment
kleimkuhler
left a comment
There was a problem hiding this comment.
Looks good! Looks like changes #560 were included in this just a heads up.
Contributor
Author
Yup, the commit message notes that this depends on that branch :) |
Signed-off-by: Eliza Weisman <[email protected]>
The way Hyepr handles disconnections has changed, so we no logner see this errno. This is actually more consistent with the way clean disconnections are handled for raw TCP traffic, anyway! Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
whoops --- `Vec::clear` sets the length to 0, so no bytes are read into the buffer. fixed this by just allocating a new vec like the tests used to do, it's fine, they're just tests. Signed-off-by: Eliza Weisman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch re-enables all the proxy integration tests that hadn't
already been turned back on.
It turns out that almost everything just works!
Depends on #560
Signed-off-by: Eliza Weisman [email protected]