Merged
Conversation
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
olix0r
approved these changes
Jun 12, 2020
hawkw
added a commit
that referenced
this pull request
Jun 14, 2020
This branch re-enables all the proxy integration tests that hadn't already been turned back on. It turns out that almost everything just works! Depends on #560 Signed-off-by: Eliza Weisman <[email protected]> * remove ENOTCONNs from HTTP transport metrics tests The way Hyepr handles disconnections has changed, so we no logner see this errno. This is actually more consistent with the way clean disconnections are handled for raw TCP traffic, anyway! Signed-off-by: Eliza Weisman <[email protected]> * put back upgrade service that i apparently forgot Signed-off-by: Eliza Weisman <[email protected]> * cargo.lock * fix zero length `read`s in transparency tests whoops --- `Vec::clear` sets the length to 0, so no bytes are read into the buffer. fixed this by just allocating a new vec like the tests used to do, it's fine, they're just tests. Signed-off-by: Eliza Weisman <[email protected]> Co-authored-by: Oliver Gould <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the
Draintype which powers the proxy's graceful shutdownmachinery was updated in #482, we were not actually triggering graceful
shutdowns. This is because the Hyper
ConnectionFuturewas wrapped in acompatibility adapter which did not allow access to the inner future so
that we could call the
graceful_shutdownmethod on it. When we updatedto the
std::futureversion of Hyper, the graceful shutdown code wasnot re-enabled.
This branch puts back the call to
ConnectionFuture::graceful_shutdown.It also re-enables the shutdown integration tests, which pass now.
Signed-off-by: Eliza Weisman [email protected]