move DNS resolver back to the admin thread#559
Merged
hawkw merged 1 commit intomaster-tokio-0.2from Jun 12, 2020
Merged
Conversation
Upstream changes to `trust-dns-resolver` removed the background task to drive DNS resolutions. Now, the resolution is performed as part of the lookup future. This means that resolutions are now occurring "inline" when we call into a resolver, rather than on the background thread. This caused issues with failed resolutions preventing the proxy from shutting down. This should hopefully fix that. Signed-off-by: Eliza Weisman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream changes to
trust-dns-resolverremoved the background task todrive DNS resolutions. Now, the resolution is performed as part of the
lookup future.
This means that resolutions are now occurring "inline" when we call into
a resolver, rather than on the background thread. This caused issues
with failed resolutions preventing the proxy from shutting down.
This should hopefully fix that.
Signed-off-by: Eliza Weisman [email protected]