Merged
Conversation
This CODEOWNERS change will enforce a requirement that I approve all PRs to master. This is already practically the case, but it's not codified. I'd like to follow this by relaxing the PR review requirement to 1. This allows me to merge my own PRs with only a single review, and will allow me to unblock any other PR. Practically, I plan to continue to solicit >1 review on changes; but I don't think this needs to be enforced by GitHub.
Contributor
IIRC, CODEOWNERS, on its own, doesn't actually require a review from code owners to merge a PR; it just adds you as a reviewer automatically. I think there's also a repo setting to "require a review from CODEOWNERS" that needs to be flipped.
This is basically true, yeah. I feel like I also review pretty much all proxy changes, but I don't feel like my review needs to be blocking, unlike yours. My only concern about doing this for now is bus factor --- if you're OOO for a week, we can't merge anything during that time. I don't think we would merge any major functional changes even without Github enforcing that your approval is required, and minor changes like spelling fixes or whatever could just wait until you got back, but it could be good to be able to get a hypothetical fix for a major issue through without having to track you down in the woods or whatever? |
hawkw
reviewed
Jun 11, 2020
hawkw
approved these changes
Jun 11, 2020
olix0r
added a commit
that referenced
this pull request
Jun 15, 2020
This CODEOWNERS change will ensure that proxy-maintainers are requested on all PRs.
hawkw
pushed a commit
that referenced
this pull request
Jun 15, 2020
* make: Support CARGO_TARGET for multi-arch builds (#497) This change adds support for a `CARGO_TARGET` environment variable. When set, this value is passed to i.e. `cargo build --target` to support cross-compilation for multi-architecture builds. Signed-off-by: jaerik <[email protected]> Co-authored-by: Erik Jansson <[email protected]> * Add a CODEOWNERS (#558) This CODEOWNERS change will ensure that proxy-maintainers are requested on all PRs. Co-authored-by: Erik Jansson <[email protected]> Co-authored-by: Erik Jansson <[email protected]>
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Jun 23, 2020
This release primarily features an upgrade of the proxy's underlying Tokio runtime and its related libraries. We've observed lower latencies in initial benchmarks, but further testing and burn-in is warranted. Also, the proxy now honors the `LINKERD_PROXY_LOG_FORMAT=json` configuration to enable JSON-formatted logging. --- * Add a CODEOWNERS (linkerd/linkerd2-proxy#558) * Fix shellcheck issues in shell scripts (linkerd/linkerd2-proxy#554) * update the proxy to use std::future and Tokio 0.2 (linkerd/linkerd2-proxy#568) * Prune unused dependencies (linkerd/linkerd2-proxy#569) * Support LINKERD_PROXY_LOG_FORMAT=json (linkerd/linkerd2-proxy#500) * Change docs references from "master" to "main" (linkerd/linkerd2-proxy#571) * Upgrade tokio-rustls & webpki. (linkerd/linkerd2-proxy#570) * Makefile: Add shellcheck recipe (linkerd/linkerd2-proxy#555) * Update proxy-api dependencies (linkerd/linkerd2-proxy#573) * integration: fix missing traces (linkerd/linkerd2-proxy#572) * Update Rust to 1.44.0 (linkerd/linkerd2-proxy#574) * Use async/await to simplify connection-accept task (linkerd/linkerd2-proxy#575) * Update Rust to 1.44.1 (linkerd/linkerd2-proxy#576) * outbound: Split HTTP endpoint builder (linkerd/linkerd2-proxy#578) * Simplify protocol detection with async/await (linkerd/linkerd2-proxy#577) * Pin proxy-api at v0.1.13 (linkerd/linkerd2-proxy#579)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Jun 24, 2020
This release primarily features an upgrade of the proxy's underlying Tokio runtime and its related libraries. We've observed lower latencies in initial benchmarks, but further testing and burn-in is warranted. Also, the proxy now honors the `LINKERD_PROXY_LOG_FORMAT=json` configuration to enable JSON-formatted logging. --- * Add a CODEOWNERS (linkerd/linkerd2-proxy#558) * Fix shellcheck issues in shell scripts (linkerd/linkerd2-proxy#554) * update the proxy to use std::future and Tokio 0.2 (linkerd/linkerd2-proxy#568) * Prune unused dependencies (linkerd/linkerd2-proxy#569) * Support LINKERD_PROXY_LOG_FORMAT=json (linkerd/linkerd2-proxy#500) * Change docs references from "master" to "main" (linkerd/linkerd2-proxy#571) * Upgrade tokio-rustls & webpki. (linkerd/linkerd2-proxy#570) * Makefile: Add shellcheck recipe (linkerd/linkerd2-proxy#555) * Update proxy-api dependencies (linkerd/linkerd2-proxy#573) * integration: fix missing traces (linkerd/linkerd2-proxy#572) * Update Rust to 1.44.0 (linkerd/linkerd2-proxy#574) * Use async/await to simplify connection-accept task (linkerd/linkerd2-proxy#575) * Update Rust to 1.44.1 (linkerd/linkerd2-proxy#576) * outbound: Split HTTP endpoint builder (linkerd/linkerd2-proxy#578) * Simplify protocol detection with async/await (linkerd/linkerd2-proxy#577) * Pin proxy-api at v0.1.13 (linkerd/linkerd2-proxy#579)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CODEOWNERS change will ensure that proxy-maintainers are requested on all PRs.