update linkerd2-error-metrics to std::future#557
Merged
hawkw merged 2 commits intomaster-tokio-0.2from Jun 12, 2020
Merged
Conversation
Looks like the `linkerd2-error-metrics` crate was never updated to `std::future`. This branch takes care of that and adds back the HTTP error metrics layers. This should be a pretty trivial review. Signed-off-by: Eliza Weisman <[email protected]>
hawkw
force-pushed
the
eliza/0.2-error-metrics
branch
from
f23aac1 to
0d896a8
Compare
olix0r
approved these changes
Jun 11, 2020
but, whatever Signed-off-by: Eliza Weisman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the
linkerd2-error-metricscrate was never updated tostd::future. This branch takes care of that and adds back the HTTPerror metrics layers.
This should be a pretty trivial review.
Signed-off-by: Eliza Weisman [email protected]