update require_identity_on_endpoint to std::future#553
Merged
hawkw merged 2 commits intomaster-tokio-0.2from Jun 11, 2020
Merged
update require_identity_on_endpoint to std::future#553hawkw merged 2 commits intomaster-tokio-0.2from
hawkw merged 2 commits intomaster-tokio-0.2from
Conversation
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
kleimkuhler
approved these changes
Jun 9, 2020
olix0r
approved these changes
Jun 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch updates the
require_identity_on_endpointmodule inlinkerd2-app-outboundtostd::future.The tests for this functionality
(
require_id_header::http2::disco_client_connects_to_tls_serverandrequire_id_header::http1::disco_client_connects_to_tls_server) nowpass; however, they had already been re-enabled (they are tagged as
flaky).
Signed-off-by: Eliza Weisman [email protected]