Skip to content

update OpenCensus to Tonic/std::future#552

Merged
hawkw merged 10 commits intomaster-tokio-0.2from
eliza/0.2-opencensus-2
Jun 9, 2020
Merged

update OpenCensus to Tonic/std::future#552
hawkw merged 10 commits intomaster-tokio-0.2from
eliza/0.2-opencensus-2

Conversation

@hawkw
Copy link
Contributor

@hawkw hawkw commented Jun 8, 2020

Note: this branch was already approved (as #543), but was
accidentally merged into the dev branch for #541, which it depended
on and was set as the base until that branch merged. It looks like,
when merging #543, I forgot to change the base branch back to
master-tokio-0.2, and these changes never made it to master.


This branch updates the proxy's OpenCensus tracing code and collector
client to use Tonic and std::future, and puts the OpenCensus stack
layers back in the inbound and outbound proxy.

Of note: the previous implementation constructed a single client
Service which was reused when restarting a new RPC if the stream
terminated. Because Tonic's generated RPCs borrow the client service
mutably for the duration of the RPC future, if we want these futures to
be 'static, we must move the service into the future. Rather than
requiring the service to be Clone, I solved this by replacing the
Service instance held by the client with a NewService instance. I
don't think this should be an issue, let me know if I'm wrong?

I'd like to do some additional testing with the OpenCensus integration
tests but I'm opening this PR now to start getting reviews.

Signed-off-by: Eliza Weisman [email protected]

hawkw added 8 commits June 8, 2020 10:27
(where "works" == "compiles")

Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
@hawkw hawkw requested review from a team, adleong and olix0r June 8, 2020 17:33
@hawkw hawkw self-assigned this Jun 8, 2020
hawkw added 2 commits June 8, 2020 11:29
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
@hawkw hawkw requested a review from a team June 8, 2020 20:06
@hawkw hawkw merged commit 2d7b810 into master-tokio-0.2 Jun 9, 2020
@olix0r olix0r deleted the eliza/0.2-opencensus-2 branch May 25, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants