update OpenCensus to Tonic/std::future#552
Merged
hawkw merged 10 commits intomaster-tokio-0.2from Jun 9, 2020
Merged
Conversation
Signed-off-by: Eliza Weisman <[email protected]>
(where "works" == "compiles") Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
olix0r
approved these changes
Jun 8, 2020
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
kleimkuhler
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this branch was already approved (as #543), but was
accidentally merged into the dev branch for #541, which it depended
on and was set as the base until that branch merged. It looks like,
when merging #543, I forgot to change the base branch back to
master-tokio-0.2, and these changes never made it to master.This branch updates the proxy's OpenCensus tracing code and collector
client to use Tonic and
std::future, and puts the OpenCensus stacklayers back in the inbound and outbound proxy.
Of note: the previous implementation constructed a single client
Servicewhich was reused when restarting a new RPC if the streamterminated. Because Tonic's generated RPCs borrow the client service
mutably for the duration of the RPC future, if we want these futures to
be
'static, we must move the service into the future. Rather thanrequiring the service to be
Clone, I solved this by replacing theServiceinstance held by the client with aNewServiceinstance. Idon't think this should be an issue, let me know if I'm wrong?
I'd like to do some additional testing with the OpenCensus integration
tests but I'm opening this PR now to start getting reviews.
Signed-off-by: Eliza Weisman [email protected]