Skip to content

update tap to std::future#551

Merged
hawkw merged 20 commits intomaster-tokio-0.2from
eliza/0.2-tap
Jun 11, 2020
Merged

update tap to std::future#551
hawkw merged 20 commits intomaster-tokio-0.2from
eliza/0.2-tap

Conversation

@hawkw
Copy link
Contributor

@hawkw hawkw commented Jun 5, 2020

This branch updates the proxy tap machinery to use std::future and
Tonic.

Depends on #548

Signed-off-by: Eliza Weisman [email protected]

@hawkw hawkw requested review from a team and olix0r June 5, 2020 01:29
@hawkw hawkw force-pushed the eliza/0.2-tap branch 2 times, most recently from 188a8c1 to 05e7ae7 Compare June 5, 2020 18:08
@hawkw hawkw changed the base branch from master-tokio-0.2 to eliza/0.2-identity June 5, 2020 18:09
@olix0r
Copy link
Member

olix0r commented Jun 8, 2020

i think this needs a different base branch?

@hawkw hawkw changed the base branch from eliza/0.2-identity to master-tokio-0.2 June 8, 2020 19:44
@hawkw
Copy link
Contributor Author

hawkw commented Jun 8, 2020

i think this needs a different base branch?

whoops, should be all good now!

Copy link
Contributor

@kleimkuhler kleimkuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

hawkw and others added 19 commits June 9, 2020 09:15
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Copy link
Member

@olix0r olix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hawkw hawkw merged commit bd4a0cd into master-tokio-0.2 Jun 11, 2020
@olix0r olix0r deleted the eliza/0.2-tap branch May 25, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants