propagate spans to tasks spawned by Hyper#550
Merged
hawkw merged 1 commit intomaster-tokio-0.2from Jun 8, 2020
Merged
Conversation
Previously, in the `futures` 0.1 version of the proxy, we provided `hyper` with a custom executor to propagate `tracing` spans to tasks spawned by `hyper`. In the process of updating the proxy to `std::future`, this was removed, meaning that any tasks spawned by hyper are missing their spans. This makes events recorded by `h2` and so on hard to debug, especially when many connections are open. This branch fixes this by adding an implementation of `hyper::Executor` that propagates the current span when spawning a task. Signed-off-by: Eliza Weisman <[email protected]>
olix0r
approved these changes
Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, in the
futures0.1 version of the proxy, we providedhyperwith a custom executor to propagatetracingspans to tasksspawned by
hyper. In the process of updating the proxy tostd::future, this was removed, meaning that any tasks spawned by hyperare missing their spans. This makes events recorded by
h2and so onhard to debug, especially when many connections are open.
This branch fixes this by adding an implementation of
hyper::Executorthat propagates the current span when spawning a task.
Signed-off-by: Eliza Weisman [email protected]