update linkerd2-error-respond to std::future#536
Merged
hawkw merged 3 commits intomaster-tokio-0.2from May 27, 2020
Merged
Conversation
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
olix0r
approved these changes
May 27, 2020
hawkw
added a commit
that referenced
this pull request
May 29, 2020
This branch updates the service profiles controller client and stack layers to `std::future`, and puts service profiles back in the outbound and inbound stacks. Retries do not actually happen yet because the retry code hasn't been updated. All of the tests for profile destination overrides can now be re-enabled. In addition, some of the the tests in `profiles.rs` could also be re-enabled, with the exception of the ones that actually expect retries to happen. Depends on #536. Signed-off-by: Eliza Weisman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch updates the
linkerd2-error-respondmiddleware tostd::future,and puts back the error response layers in the inbound and outbound stacks.
This is pretty straightforward and shouldn't take a whole lot of time to review.
Signed-off-by: Eliza Weisman [email protected]