update linkerd2-proxy-api-resolve to use Tonic#519
Merged
hawkw merged 5 commits intomaster-tokio-0.2from May 20, 2020
Merged
Conversation
olix0r
approved these changes
May 19, 2020
Member
olix0r
left a comment
olix0r
left a comment
There was a problem hiding this comment.
don't forget to change the base branch before you merge ;)
hawkw
force-pushed
the
eliza/0.2-api-resolve
branch
from
10c9ca1 to
4c49d9d
Compare
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
force-pushed
the
eliza/0.2-api-resolve
branch
from
4c49d9d to
ff64912
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch updates the
linkerd2-proxy-api-resolvecrate to usestd::futureand Tonic. Getting this to work required some upstreamchanges to linkerd/linkerd2-proxy-api#39 to pass different feature flags
to Tonic, but the change here is pretty straigntforward.
Depends on #518 and will be rebased onto
master-tokio-02when that branch merges.