port normalize_uri to std::future#517
Merged
hawkw merged 2 commits intomaster-tokio-0.2from May 14, 2020
Merged
Conversation
It turns out that most of the tests that can be re-enabled as a result of #516 expect URIs to be normalized. Therefore, I ported the `normalize_uri` layer to std::future. This is a pretty mechanical translation. Signed-off-by: Eliza Weisman <[email protected]>
kleimkuhler
approved these changes
May 14, 2020
Signed-off-by: Eliza Weisman <[email protected]>
olix0r
approved these changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that most of the tests that can be re-enabled as a result
of #516 expect URIs to be normalized.
Therefore, I ported the
normalize_urilayer to std::future. This isa pretty mechanical translation.
Signed-off-by: Eliza Weisman [email protected]