fix concurrency-limit not polling inner service#506
Merged
hawkw merged 1 commit intomaster-tokio-0.2from May 7, 2020
Merged
Conversation
This fixes a bug where the std::future version of `linkerd-concurrency-limit` fails to drive the wrapped service to readiness before calling it. Now, the inner service is polled once a semaphore permit has been acquired. Shoutout to @LucioFranco for noticing this! Signed-off-by: Eliza Weisman <[email protected]>
|
Thanks to @bruceg he found it! 😄 |
olix0r
approved these changes
May 6, 2020
kleimkuhler
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the std::future version of
linkerd-concurrency-limitfails to drive the wrapped service toreadiness before calling it. Now, the inner service is polled once a
semaphore permit has been acquired.
Shoutout to @LucioFranco for noticing this!
Signed-off-by: Eliza Weisman [email protected]