Set a grpc-status of UNAVAILABLE only on io errors#498
Merged
Conversation
In #493, we opted to handle all hyper errors as `UNAVAILABLE` for gRPC messages. This change modifies the signature of `http_status` & `set_grpc_status` so that we can unwrap arbitrary inner errors via `Error::source`. This reduces some unnecessary special-casing and allows us to more-narrowly target IO errors.
hawkw
approved these changes
Apr 30, 2020
kleimkuhler
approved these changes
May 1, 2020
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
May 7, 2020
This release modifies Linkerd's internal buffering to avoid idling out services as a request arrives. This could cause failures for requests that are sent exactly once per minute, such as Prometheus scrapes. --- * Handle GRPC body errors (linkerd/linkerd2-proxy#493) * Set a grpc-status of UNAVAILABLE only on io errors (linkerd/linkerd2-proxy#498) * inbound: Remove unnecessary buffer (linkerd/linkerd2-proxy#501) * buffer: Move idle timeouts into the buffer (linkerd/linkerd2-proxy#502) * make: Support CARGO_TARGET for multi-arch builds (linkerd/linkerd2-proxy#497) * release: Use arch-specific paths (linkerd/linkerd2-proxy#508)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
May 7, 2020
This release modifies Linkerd's internal buffering to avoid idling out services as a request arrives. This could cause failures for requests that are sent exactly once per minute, such as Prometheus scrapes. --- * Set a grpc-status of UNAVAILABLE only on io errors (linkerd/linkerd2-proxy#498) * inbound: Remove unnecessary buffer (linkerd/linkerd2-proxy#501) * buffer: Move idle timeouts into the buffer (linkerd/linkerd2-proxy#502) * make: Support CARGO_TARGET for multi-arch builds (linkerd/linkerd2-proxy#497) * release: Use arch-specific paths (linkerd/linkerd2-proxy#508)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
May 7, 2020
This release modifies Linkerd's internal buffering to avoid idling out services as a request arrives. This could cause failures for requests that are sent exactly once per minute, such as Prometheus scrapes. --- * Set a grpc-status of UNAVAILABLE only on io errors (linkerd/linkerd2-proxy#498) * inbound: Remove unnecessary buffer (linkerd/linkerd2-proxy#501) * buffer: Move idle timeouts into the buffer (linkerd/linkerd2-proxy#502) * make: Support CARGO_TARGET for multi-arch builds (linkerd/linkerd2-proxy#497) * release: Use arch-specific paths (linkerd/linkerd2-proxy#508)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #493, we opted to handle all hyper errors as
UNAVAILABLEfor gRPCmessages.
This change modifies the signature of
http_status&set_grpc_statusso that we can unwrap arbitrary inner errors via
Error::source. Thisreduces some unnecessary special-casing and allows us to more-narrowly
target IO errors
Special thanks to @LucioFranco for guiding me in the right direction on this.