Adapting makefile for multiarch builds#497
Merged
olix0r merged 1 commit intolinkerd:masterfrom May 6, 2020
Merged
Conversation
jaerik
force-pushed
the
jaerik-multiarch-build
branch
from
198a7a5 to
cd1105c
Compare
Member
|
Thanks @jaerik! This looks great. You don't have to necessarily make these changes in this branch: but do you have any thoughts on how we can support these builds in our release process? Our release process is driven by this github action: I assume that we need to figure out a way to produce binaries for each of the target platforms. Can we do this easily in Actions? If not, we may be able to provision build hosts for the target platforms... Anyway, this isn't a blocker; but I'd love to figure out a way to support these artifacts as a part of our automated release process. (Until then, it will be hard for us to consider these builds officially supported). |
Member
|
This CI failure is an issue with actions, not this branch. |
olix0r
approved these changes
Apr 30, 2020
kleimkuhler
reviewed
Apr 30, 2020
Signed-off-by: jaerik <[email protected]>
jaerik
force-pushed
the
jaerik-multiarch-build
branch
from
cd1105c to
0d647f5
Compare
Contributor
Author
@olix0r I think you just can add a new action step for each target platform, e.g:
And then just change the with-files in the realese step to: I'm not sure how to adapt the checksec step, when there are limitations when testing cross compiled systems. |
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
May 7, 2020
This release modifies Linkerd's internal buffering to avoid idling out services as a request arrives. This could cause failures for requests that are sent exactly once per minute, such as Prometheus scrapes. --- * Handle GRPC body errors (linkerd/linkerd2-proxy#493) * Set a grpc-status of UNAVAILABLE only on io errors (linkerd/linkerd2-proxy#498) * inbound: Remove unnecessary buffer (linkerd/linkerd2-proxy#501) * buffer: Move idle timeouts into the buffer (linkerd/linkerd2-proxy#502) * make: Support CARGO_TARGET for multi-arch builds (linkerd/linkerd2-proxy#497) * release: Use arch-specific paths (linkerd/linkerd2-proxy#508)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
May 7, 2020
This release modifies Linkerd's internal buffering to avoid idling out services as a request arrives. This could cause failures for requests that are sent exactly once per minute, such as Prometheus scrapes. --- * Set a grpc-status of UNAVAILABLE only on io errors (linkerd/linkerd2-proxy#498) * inbound: Remove unnecessary buffer (linkerd/linkerd2-proxy#501) * buffer: Move idle timeouts into the buffer (linkerd/linkerd2-proxy#502) * make: Support CARGO_TARGET for multi-arch builds (linkerd/linkerd2-proxy#497) * release: Use arch-specific paths (linkerd/linkerd2-proxy#508)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
May 7, 2020
This release modifies Linkerd's internal buffering to avoid idling out services as a request arrives. This could cause failures for requests that are sent exactly once per minute, such as Prometheus scrapes. --- * Set a grpc-status of UNAVAILABLE only on io errors (linkerd/linkerd2-proxy#498) * inbound: Remove unnecessary buffer (linkerd/linkerd2-proxy#501) * buffer: Move idle timeouts into the buffer (linkerd/linkerd2-proxy#502) * make: Support CARGO_TARGET for multi-arch builds (linkerd/linkerd2-proxy#497) * release: Use arch-specific paths (linkerd/linkerd2-proxy#508)
olix0r
pushed a commit
that referenced
this pull request
Jun 15, 2020
This change adds support for a `CARGO_TARGET` environment variable. When set, this value is passed to i.e. `cargo build --target` to support cross-compilation for multi-architecture builds. Signed-off-by: jaerik <[email protected]> Co-authored-by: Erik Jansson <[email protected]>
hawkw
pushed a commit
that referenced
this pull request
Jun 15, 2020
* make: Support CARGO_TARGET for multi-arch builds (#497) This change adds support for a `CARGO_TARGET` environment variable. When set, this value is passed to i.e. `cargo build --target` to support cross-compilation for multi-architecture builds. Signed-off-by: jaerik <[email protected]> Co-authored-by: Erik Jansson <[email protected]> * Add a CODEOWNERS (#558) This CODEOWNERS change will ensure that proxy-maintainers are requested on all PRs. Co-authored-by: Erik Jansson <[email protected]> Co-authored-by: Erik Jansson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to to build the linkerd2-proxy for other architectures the than the host architecture with make. This by updating the makefile to be aware of environment variables specifying the target architecture.