Remove unneeded PhantomData#494
Merged
zaharidichev merged 1 commit intozd/handle-grpc-body-errorsfrom Apr 29, 2020
Merged
Conversation
The changes to the `Respond` trait eliminate the need for our implementation to track the repsonse-body type via `PhantomData`.
olix0r
commented
Apr 28, 2020
| #[derive(Debug)] | ||
| pub struct NewRespond<B>(std::marker::PhantomData<fn() -> B>); | ||
| #[derive(Copy, Clone, Debug)] | ||
| pub struct NewRespond(()); |
Member
Author
There was a problem hiding this comment.
note: this is done to prevent instantiation NewRespond directly from outside of this module. not critical but something we do frequently to encourage going through the constructors.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes to the
Respondtrait eliminate the need for ourimplementation to track the repsonse-body type via
PhantomData.