update everything to use the Git version of tower#489
Merged
hawkw merged 1 commit intomaster-tokio-0.2from Apr 24, 2020
Merged
Conversation
Tower is currently being reorganized (all the sub-crates are being merged into feature-flagged modules of the main `tower` crate). This hasn't been released yet, but it has landed on git master. In addition, we need to pick up an upstream fix for a regression in the future returned by `ServiceExt::oneshot` (tower-rs/tower#447), which is currently unreleased; without this fix, a lot of stuff is broken and it's difficult to test changes in other linkerd crates. This branch updates everything that currently depends on `tower` 0.3 to use the same dependency, and enables the features that each crate currently uses in that crate's dependency. I've added a single patch to use the git version in the main workspace `Cargo.toml`; when the changes we need are published, the patch can be removed. Signed-off-by: Eliza Weisman <[email protected]>
olix0r
approved these changes
Apr 24, 2020
kleimkuhler
approved these changes
Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tower is currently being reorganized (all the sub-crates are being
merged into feature-flagged modules of the main
towercrate). Thishasn't been released yet, but it has landed on git master. In addition,
we need to pick up an upstream fix for a regression in the future
returned by
ServiceExt::oneshot(tower-rs/tower#447), which iscurrently unreleased; without this fix, a lot of stuff is broken and
it's difficult to test changes in other linkerd crates.
This branch updates everything that currently depends on
tower0.3 touse the same dependency, and enables the features that each crate
currently uses in that crate's dependency. I've added a single patch to
use the git version in the main workspace
Cargo.toml; when the changeswe need are published, the patch can be removed.
Signed-off-by: Eliza Weisman [email protected]