port timeout (and friends) to std::future#486
Merged
hawkw merged 7 commits intomaster-tokio-0.2from Apr 23, 2020
Merged
Conversation
Member
|
To be clear... this depends on/follows #482? Should I review that one first? |
Contributor
Author
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
force-pushed
the
eliza/0.2-timeout
branch
from
02b920b to
48a042a
Compare
Contributor
Author
|
Rebased onto |
olix0r
approved these changes
Apr 22, 2020
Member
olix0r
left a comment
olix0r
left a comment
There was a problem hiding this comment.
So happy to see the tokio::test cleanups!
Contributor
Author
The |
Signed-off-by: Eliza Weisman <[email protected]>
kleimkuhler
approved these changes
Apr 23, 2020
Contributor
kleimkuhler
left a comment
kleimkuhler
left a comment
There was a problem hiding this comment.
Looks good! +1 on the test cleanups!
hawkw
added a commit
that referenced
this pull request
Apr 24, 2020
This branch ports the `linkerd2-buffer` to use `std::future` and `tokio` 0.2. I've also re-enabled the `push_spawn_buffer` fns in `svc`. Like #486 and #487, this change should be pretty straightforward to read, as it's fairly mechanical in nature. I've basically just changed the code to account for the new APIs. This one might be a _little_ more interesting, since it shows off some of the API differences in `tokio::sync` in 0.2 as well. Signed-off-by: Eliza Weisman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch ports the
linkerd2-timeoutcrate and thelinkerd2-proxy-httpcrate'stimeoutmodule (which depends on it) touse
std::futureandtokio0.2's timers. I've also re-enabled thepush_*methods fortimeout,probe_ready,fail_fast, andidle,as well.
This change should be pretty straightforward to read, as it's fairly
mechanical in nature. I've basically just changed the code to account
for the new APIs, but the implementation should be quite similar.