Adjust metric description.#484
Merged
grampelberg merged 1 commit intolinkerd:masterfrom Apr 17, 2020
naseemkullah:retry-metric-description
Merged
Adjust metric description.#484grampelberg merged 1 commit intolinkerd:masterfrom naseemkullah:retry-metric-description
grampelberg merged 1 commit intolinkerd:masterfrom
naseemkullah:retry-metric-description
Conversation
The retryable HTTP responses that were not retries are only those with the skipped: no_budget label. Actual retries that occured fall under this metric category. Signed-off-by: Naseem <[email protected]>
grampelberg
approved these changes
Apr 17, 2020
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Apr 22, 2020
This release introduces a per-endpoint authority-override feature. This is driven by the destination controller and is needed to support mutli-cluster gateways. --- * Update to Rust 1.42.0 (linkerd/linkerd2-proxy#483) * Adjust metric description. (linkerd/linkerd2-proxy#484) * Use authority override from metadata (linkerd/linkerd2-proxy#458)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Apr 22, 2020
This release introduces a per-endpoint authority-override feature. This is driven by the destination controller and is needed to support mutli-cluster gateways. --- * Update to Rust 1.42.0 (linkerd/linkerd2-proxy#483) * Adjust metric description. (linkerd/linkerd2-proxy#484) * Use authority override from metadata (linkerd/linkerd2-proxy#458)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retryable HTTP responses that were not retries are only those with the skipped: no_budget label. Actual retries that occured fall under this metric category.
Signed-off-by: Naseem [email protected]