prepare to update the proxy to use std::future#473
Conversation
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
|
How do you want to handle integration tests on this branch? I think our options are:
|
|
It would be good to keep checking that the tests compile though, even if we don't actually run them. Also, I think we'll want to be able to turn them back on incrementally as the relevant parts of the proxy are ported over. So I'm not sure if just turning off the integration workflow is really ideal? I think the right move would be to replace all the |
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
|
@olix0r okay, I think I've settled on a scheme for ignoring tests in 8eb6061. I've added What do you think? |
|
@hawkw that sounds reasonable |
hawkw
changed the title
3 participants
This branch begins a "top-down" update of the proxy to use
std::future. I've started by commenting out most of the stack, makingthe proxy into a raw TCP forwarder/HTTP server that just always returns
200 OK <eof>. Then, I've updated the top-levelservefunction to usestd::future. This is pretty mechanical, but we may want to considerdoing some refactoring here in the future.
Currently, most of the integration tests are failing, since they test
functionality that is now commented out. I've added
ignoreattributestemporarily to disable those tests. However, since we are ignoring the
tests rather than disabling them via conditional compilation, we will
still try to build them, so this ensures we don't accidentally break any
of these tests. There is a feature flag, "nyi", that can be enabled to
run the ignored tests, so that we can test if changes have made any
additional tests pass again. As functionality is re-enabled, we can
re-enable the corresponding tests as well.