http-metrics: Make latency export optional#467
Merged
Conversation
We export raw histograms for all HTTP metrics layers; but in some cases these values are never consumed. This change modifies the http metrics `Report` type to support disabling export of latencies. This feature is not used yet but will be used in a follow-up.
adleong
approved these changes
Mar 31, 2020
Member
Author
|
@adleong that's right. as i noted in the description, we can figure out if it make sense to go deeper with this, but in the name of expediency, I think this is the right change. |
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Mar 31, 2020
This release restores the `route_actual_response_total` metric, which is needed for `linkerd routes -o wide`. --- * Update test certificates (linkerd/linkerd2-proxy#460) * Use strong_count instead of upgrade on weak Arcs in cache (linkerd/linkerd2-proxy#459) * Wire authority override coming from discovery (linkerd/linkerd2-proxy#462) * Update integration tests certs (linkerd/linkerd2-proxy#465) * Add a `mock-orig-dst` feature flag (linkerd/linkerd2-proxy#466) * http-metrics: Make latency export optional (linkerd/linkerd2-proxy#467) * Restore the route_actual_response_total metric (linkerd/linkerd2-proxy#468)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Mar 31, 2020
This release restores the `route_actual_response_total` metric, which is needed for `linkerd routes -o wide`. --- * Update test certificates (linkerd/linkerd2-proxy#460) * Use strong_count instead of upgrade on weak Arcs in cache (linkerd/linkerd2-proxy#459) * Wire authority override coming from discovery (linkerd/linkerd2-proxy#462) * Update integration tests certs (linkerd/linkerd2-proxy#465) * Add a `mock-orig-dst` feature flag (linkerd/linkerd2-proxy#466) * http-metrics: Make latency export optional (linkerd/linkerd2-proxy#467) * Restore the route_actual_response_total metric (linkerd/linkerd2-proxy#468)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We export raw histograms for all HTTP metrics layers; but in some cases
these values are never consumed. This change modifies the http metrics
Reporttype to support disabling export of latencies.This feature is not used yet but will be used in a follow-up.
We can revisit how to skip recording as well, but in order to address linkerd/linkerd2#4215 expediently, I think addressing this only on the report-side is a good stopgap.