Wire authority override coming from discovery#462
Merged
zaharidichev merged 2 commits intomasterfrom Mar 25, 2020
Merged
Conversation
Signed-off-by: Zahari Dichev <[email protected]>
zaharidichev
force-pushed
the
zd/wire-auth-override
branch
from
31d96ec to
e7aafd0
Compare
kleimkuhler
reviewed
Mar 24, 2020
Contributor
kleimkuhler
left a comment
kleimkuhler
left a comment
There was a problem hiding this comment.
Looks good. Open question from me is if we want to get a release for the proxy API out first?
| http-body = "0.1" | ||
| hyper = "0.12" | ||
| linkerd2-metrics = { path = "../metrics", features = ["test_util"] } | ||
| linkerd2-proxy-api = { git = "https://github.com/linkerd/linkerd2-proxy-api", features = ["arbitrary"], tag = "v0.1.11" } |
Contributor
There was a problem hiding this comment.
Do we want to block this getting a linkerd2-proxy-api release out first?
Member
Author
There was a problem hiding this comment.
@kleimkuhler We are using the released api now.
Signed-off-by: Zahari Dichev <[email protected]>
zaharidichev
force-pushed
the
zd/wire-auth-override
branch
from
c0a1be2 to
0894ae3
Compare
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Mar 31, 2020
This release restores the `route_actual_response_total` metric, which is needed for `linkerd routes -o wide`. --- * Update test certificates (linkerd/linkerd2-proxy#460) * Use strong_count instead of upgrade on weak Arcs in cache (linkerd/linkerd2-proxy#459) * Wire authority override coming from discovery (linkerd/linkerd2-proxy#462) * Update integration tests certs (linkerd/linkerd2-proxy#465) * Add a `mock-orig-dst` feature flag (linkerd/linkerd2-proxy#466) * http-metrics: Make latency export optional (linkerd/linkerd2-proxy#467) * Restore the route_actual_response_total metric (linkerd/linkerd2-proxy#468)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Mar 31, 2020
This release restores the `route_actual_response_total` metric, which is needed for `linkerd routes -o wide`. --- * Update test certificates (linkerd/linkerd2-proxy#460) * Use strong_count instead of upgrade on weak Arcs in cache (linkerd/linkerd2-proxy#459) * Wire authority override coming from discovery (linkerd/linkerd2-proxy#462) * Update integration tests certs (linkerd/linkerd2-proxy#465) * Add a `mock-orig-dst` feature flag (linkerd/linkerd2-proxy#466) * http-metrics: Make latency export optional (linkerd/linkerd2-proxy#467) * Restore the route_actual_response_total metric (linkerd/linkerd2-proxy#468)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the latest changes to the proxy-api and consumes the authority override data, adding to the
MetadatastructSigned-off-by: Zahari Dichev [email protected]