Merged
Conversation
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Contributor
Author
|
Rebased and updated this to the latest master. Going to do some performance testing & hopefully we can get this on the path to actually merging. |
Member
|
@hawkw Thanks! I wouldn't spend too much time on perf analysis-- I want to play around with this a little before advancing it. We're going to hold this at least until 2.7.1 is released. |
olix0r
approved these changes
Apr 10, 2020
Member
olix0r
left a comment
olix0r
left a comment
There was a problem hiding this comment.
I changed this to be based on master-tokio-0.2; so let's merge and roll forward!
hawkw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates only the proxy, not the test-support code (as suggested by @olix0r).
I'm opening this as a draft since we likely will want to wait on merging it until the performance-testing harness is in place (#406) to compare performance with tokio 0.1.