refactor(stack/switch_ready): use Either<A, B> future#3739
Merged
Conversation
this commit makes a noöp change to the `SwitchReady<A, B>` machinery provided by our `linkerd-stack` library. this commit is a small refactor that is intended to pave the way for an impending upgrade to tower v0.5, which notably includes breaking changes to the `tower::util::Either<A, B>` service. as of tower v0.5, by way of tower-rs/tower#637, the `Either<A, B>` service is no longer itself a `Future`. so, we can instead use the future provided by `futures`. for more information, see: * linkerd/linkerd2#8733 * #3504 * https://github.com/linkerd/linkerd2-proxy/pull/3504/files#r1988082658 * tower-rs/tower#637 Signed-off-by: katelyn martin <[email protected]>
sfleen
approved these changes
Mar 11, 2025
cratelyn
deleted the
kate/linkerd-stack.replace-tower-either-with-futures-either
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit makes a noöp change to the
SwitchReady<A, B>machinery provided by ourlinkerd-stacklibrary.this commit is a small refactor that is intended to pave the way for an impending upgrade to tower v0.5, which notably includes breaking changes to the
tower::util::Either<A, B>service.as of tower v0.5, by way of tower-rs/tower#637, the
Either<A, B>service is no longer itself aFuture. so, we can instead use the future provided byfutures.for more information, see:
Eithertower-rs/tower#637