Conversation
The proxy release workflow now pushes tags. When pushing a tag, we can be in the position of modifying GitHub workflows, and so we need 'workflows: write' permissons. These permisson cannot be granted to github-actions[bot]. This change updates the release worfklow to use Actions metadata to configure GitHub authentication.
github-actions bot
added a commit
to yc185050/linkerd2
that referenced
this pull request
Mar 28, 2024
--- * ci: Fix release workflow permissions (linkerd/linkerd2-proxy#2821) * build(deps): Bump tj-actions/changed-files from 43.0.0 to 43.0.1 (linkerd/linkerd2-proxy#2822) * build(deps): Bump smallvec from 1.13.1 to 1.13.2 (linkerd/linkerd2-proxy#2823) * ci: Update release workflow to use a PAT (linkerd/linkerd2-proxy#2824) * build(deps): Bump backtrace from 0.3.69 to 0.3.70 (linkerd/linkerd2-proxy#2826) * build(deps): Bump indexmap from 2.2.5 to 2.2.6 (linkerd/linkerd2-proxy#2827) * build(deps): Bump prettyplease from 0.2.16 to 0.2.17 (linkerd/linkerd2-proxy#2828) * build(deps): Bump bytes from 1.5.0 to 1.6.0 (linkerd/linkerd2-proxy#2829) * build(deps): Bump backtrace from 0.3.70 to 0.3.71 (linkerd/linkerd2-proxy#2830) * build(deps): Bump async-trait from 0.1.78 to 0.1.79 (linkerd/linkerd2-proxy#2832) * build(deps): Bump syn from 2.0.53 to 2.0.55 (linkerd/linkerd2-proxy#2831) * chore: Group HTTP crates in a directory (linkerd/linkerd2-proxy#2833) * build(deps): Bump EmbarkStudios/cargo-deny-action from 1.6.1 to 1.6.2 (linkerd/linkerd2-proxy#2825) * ci: Configure integration test retries (linkerd/linkerd2-proxy#2834) * ci: Automate weekly proxy releases (linkerd/linkerd2-proxy#2835) * build(deps): Bump autocfg from 1.1.0 to 1.2.0 (linkerd/linkerd2-proxy#2836) * build(deps): Bump fastrand from 2.0.1 to 2.0.2 (linkerd/linkerd2-proxy#2837) * build(deps): Bump itoa from 1.0.10 to 1.0.11 (linkerd/linkerd2-proxy#2838) * build(deps): Bump regex from 1.10.3 to 1.10.4 (linkerd/linkerd2-proxy#2839) * build(deps): Bump serde_json from 1.0.114 to 1.0.115 (linkerd/linkerd2-proxy#2840) * build(deps): Bump codecov/codecov-action from 4.1.0 to 4.1.1 (linkerd/linkerd2-proxy#2842) * build(deps): Bump memchr from 2.7.1 to 2.7.2 (linkerd/linkerd2-proxy#2845) * ci: Fix release version (linkerd/linkerd2-proxy#2846) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy release workflow now pushes tags. When pushing a tag, we can be in the position of modifying GitHub workflows, and so we need 'workflows: write' permissons. These permisson cannot be granted to github-actions[bot].
This change updates the release worfklow to use Actions metadata to configure GitHub authentication.