Merged
Conversation
The metrics layer did not properly count response errors. This change makes a response status code optional so that response errors may be counted when no status code is present. Fixes #2934
hawkw
approved these changes
Jun 13, 2019
Contributor
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
This LGTM! Thanks for fixing this.
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Jun 13, 2019
439fbfed Update to rust-1.35.0 (linkerd/linkerd2-proxy#265) db26495e Honor `l5d-override-dst` for inbound service profiles (linkerd/linkerd2-proxy#267) a476e995 metrics: Include the prefix of a Report in log lines (linkerd/linkerd2-proxy#262) 1a52a5e6 discovery: Fall back in MakeService, only on InvalidArgument (linkerd/linkerd2-proxy#268) 35df8ab4 metrics: Classify response errors (linkerd/linkerd2-proxy#269)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Jun 13, 2019
439fbfed Update to rust-1.35.0 (linkerd/linkerd2-proxy#265) db26495e Honor `l5d-override-dst` for inbound service profiles (linkerd/linkerd2-proxy#267) a476e995 metrics: Include the prefix of a Report in log lines (linkerd/linkerd2-proxy#262) 1a52a5e6 discovery: Fall back in MakeService, only on InvalidArgument (linkerd/linkerd2-proxy#268) 35df8ab4 metrics: Classify response errors (linkerd/linkerd2-proxy#269)
hawkw
pushed a commit
to linkerd/linkerd2
that referenced
this pull request
Jun 13, 2019
439fbfed Update to rust-1.35.0 (linkerd/linkerd2-proxy#265) db26495e Honor `l5d-override-dst` for inbound service profiles (linkerd/linkerd2-proxy#267) a476e995 metrics: Include the prefix of a Report in log lines (linkerd/linkerd2-proxy#262) 1a52a5e6 discovery: Fall back in MakeService, only on InvalidArgument (linkerd/linkerd2-proxy#268) 35df8ab4 metrics: Classify response errors (linkerd/linkerd2-proxy#269)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metrics layer did not properly count response errors.
This change makes a response status code optional so that response
errors may be counted when no status code is present.
Fixes linkerd/linkerd2#2934