outbound: add l5d-dst-canonical to requests with ServiceProfiles
#2383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #2250 removed the `l5d-dst-canonical` header from ServiceProfile requests. This header is used by the inbound proxy for telemetry purposes, so removing it and not putting it back broke ServiceProfile route metrics. This commit adds a layer for setting this header to the service profile route stack. We can also add the header for non-ServiceProfile requests if that's desirable...I'll have to look into whether it is. This commit should, at least, fix the existing ServiceProfile route metrics.
olix0r
approved these changes
Apr 7, 2023
hawkw
added a commit
to linkerd/linkerd2
that referenced
this pull request
Apr 7, 2023
This proxy release includes a fix for outbound proxies not setting the `l5d-canonical-dst` header, which results in missing inbound ServiceProfile route metrics (#10521). --- * outbound: add `l5d-dst-canonical` to requests with ServiceProfiles (linkerd/linkerd2-proxy#2383)
hawkw
added a commit
to linkerd/linkerd2
that referenced
this pull request
Apr 8, 2023
This proxy release introduces a new `outbound_http_balancer_endpoints` gauge metric which allows tracking the number of endpoints in a load balancer by their readiness status. Additionally, it includes a fix for outbound proxies not setting the `l5d-canonical-dst` header, which results in missing inbound ServiceProfile route metrics (#10521). --- * outbound: Report HTTP balancer endpoint gauges (linkerd/linkerd2-proxy#2380) * outbound: add `l5d-dst-canonical` to requests with ServiceProfiles (linkerd/linkerd2-proxy#2383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2250 removed the
l5d-dst-canonicalheader from ServiceProfile requests. This header is used by the inbound proxy for telemetry purposes, so removing it and not putting it back broke ServiceProfile route metrics. This commit adds a layer for setting this header to the service profile route stack.We can also add the header for non-ServiceProfile requests if that's desirable...I'll have to look into whether it is. This commit should, at least, fix the existing ServiceProfile route metrics.