Disable potentially info-leaking headers#231
Merged
Conversation
The proxy has been instrumented to expose various informational `l5d-` headers to expose identity and network information that would otherwise be unaccessible to the application. However, as described in linkerd/linkerd2#2597, when linkerd is injected into an ingress pod, its easy to accidentally leak these details to external applications. Until we have a better mechanism for flagging external-facing pods, these headers should be disabled.
hawkw
approved these changes
Apr 1, 2019
Contributor
|
FWIW, I do recall having a conversation on Linkerd slack with at least one user who was (at least planning on) using the |
Contributor
|
@olix0r Do we want to pull this in for the edge? |
hawkw
added a commit
that referenced
this pull request
Apr 2, 2019
These were previously disabled on master, but re-enabled when support for identity was added to the test support code. PR #231 also broke these tests, but didn't add an ignore attribute because they were already disabled when that branch was forked. Signed-off-by: Eliza Weisman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy has been instrumented to expose various informational
l5d-headers to expose identity and network information that would otherwise
be unaccessible to the application.
However, as described in linkerd/linkerd2#2597, when linkerd is injected
into an ingress pod, its easy to accidentally leak these details to
external applications.
Until we have a better mechanism for flagging external-facing pods,
these headers should be disabled.