Add test that proxy refreshes its identity#229
Merged
Conversation
seanmonstar
approved these changes
Apr 2, 2019
hawkw
changed the title
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
force-pushed
the
eliza/id-refresh-tests
branch
from
8ce6753 to
9d44a93
Compare
Signed-off-by: Eliza Weisman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #227 and #228.
This branch adds a new integration test that asserts that a proxy will
refresh its identity before the specified expiration time.
I also added a
tracelog in theidentitymodule that logs the actualduration we will wait before attempting to refresh. This was useful when
debugging why this test was failing (it was because I neglected to set
the LINKERD2_PROXY_IDENTITY_MIN_REFRESH env var, and it defaulted to 10
seconds). I felt like it was useful to log the actual duration we will
wait as well as the
SystemTimewhen the cert expires, but I'm happy toback that commit off if we don't actually want that log line.
Closes linkerd/linkerd2#2505
Signed-off-by: Eliza Weisman [email protected]