Skip to content

update Tower to 0.4.13 to fix load balancer panic#1758

Merged
olix0r merged 3 commits intomainfrom
eliza/tower-0.4.13
Jun 17, 2022
Merged

update Tower to 0.4.13 to fix load balancer panic#1758
olix0r merged 3 commits intomainfrom
eliza/tower-0.4.13

Conversation

@hawkw
Copy link
Contributor

@hawkw hawkw commented Jun 17, 2022

Tower v0.4.13 includes a fix for a bug in the tower::ready_cache
module, tower-rs/tower#415. The ready_cache module is used internally
in Tower's load balancer. This bug resulted in panics in the proxy
(linkerd/linkerd2#8666, linkerd/linkerd2#6086) in cases where the
Destination service sends a very large number of service discovery
updates (see linkerd/linkerd2#8677).

This commit updates the proxy's dependency on tower to 0.4.13, to
ensure that this bugfix is picked up.

Fixes linkerd/linkerd2#8666
Fixes linkerd/linkerd2#6086

Tower [v0.4.13] includes a fix for a bug in the `tower::ready_cache`
module, tower-rs/tower#415. The `ready_cache` module is used internally
in Tower's load balancer. This bug resulted in panics in the proxy
(linkerd/linkerd2#8666, linkerd/linkerd2#6086) in cases where the
Destination service sends a very large number of service discovery
updates (see linkerd/linkerd2#8677).

This commit updates the proxy's dependency on `tower` to 0.4.13, to
ensure that this bugfix is picked up.

Fixes linkerd/linkerd2#8666
Fixes linkerd/linkerd2#6086

[v0.4.13]: https://github.com/tower-rs/tower/releases/tag/tower-0.4.13
@hawkw hawkw requested a review from a team as a code owner June 17, 2022 20:13
@olix0r olix0r merged commit 16ec721 into main Jun 17, 2022
@olix0r olix0r deleted the eliza/tower-0.4.13 branch June 17, 2022 20:40
olix0r added a commit to linkerd/linkerd2 that referenced this pull request Jun 17, 2022
This release fixes a bug in the proxy's outbound load balancer that
could cause panics, especially when the balancer processes many service
discovery updates in a short period of time.

---

* build(deps): bump tracing from 0.1.34 to 0.1.35 (linkerd/linkerd2-proxy#1744)
* build(deps): bump tj-actions/changed-files from 22.2 to 23 (linkerd/linkerd2-proxy#1745)
* build(deps): bump getrandom from 0.2.6 to 0.2.7 (linkerd/linkerd2-proxy#1746)
* build(deps): bump unicode-ident from 1.0.0 to 1.0.1 (linkerd/linkerd2-proxy#1747)
* build(deps): bump wasm-bindgen from 0.2.80 to 0.2.81 (linkerd/linkerd2-proxy#1749)
* build(deps): bump web-sys from 0.3.57 to 0.3.58 (linkerd/linkerd2-proxy#1751)
* build(deps): bump arbitrary from 1.1.0 to 1.1.2 (linkerd/linkerd2-proxy#1754)
* build(deps): bump indexmap from 1.8.2 to 1.9.0 (linkerd/linkerd2-proxy#1756)
* build(deps): bump prettyplease from 0.1.11 to 0.1.12 (linkerd/linkerd2-proxy#1757)
* update Tower to 0.4.13 to fix load balancer panic (linkerd/linkerd2-proxy#1758)

Signed-off-by: Oliver Gould <[email protected]>
olix0r added a commit to linkerd/linkerd2 that referenced this pull request Jun 17, 2022
This release fixes a bug in the proxy's outbound load balancer that
could cause panics, especially when the balancer processes many service
discovery updates in a short period of time.

---

* build(deps): bump tracing from 0.1.34 to 0.1.35 (linkerd/linkerd2-proxy#1744)
* build(deps): bump tj-actions/changed-files from 22.2 to 23 (linkerd/linkerd2-proxy#1745)
* build(deps): bump getrandom from 0.2.6 to 0.2.7 (linkerd/linkerd2-proxy#1746)
* build(deps): bump unicode-ident from 1.0.0 to 1.0.1 (linkerd/linkerd2-proxy#1747)
* build(deps): bump wasm-bindgen from 0.2.80 to 0.2.81 (linkerd/linkerd2-proxy#1749)
* build(deps): bump web-sys from 0.3.57 to 0.3.58 (linkerd/linkerd2-proxy#1751)
* build(deps): bump arbitrary from 1.1.0 to 1.1.2 (linkerd/linkerd2-proxy#1754)
* build(deps): bump indexmap from 1.8.2 to 1.9.0 (linkerd/linkerd2-proxy#1756)
* build(deps): bump prettyplease from 0.1.11 to 0.1.12 (linkerd/linkerd2-proxy#1757)
* update Tower to 0.4.13 to fix load balancer panic (linkerd/linkerd2-proxy#1758)

Signed-off-by: Oliver Gould <[email protected]>
hawkw added a commit that referenced this pull request Jun 30, 2022
Tower [v0.4.13] includes a fix for a bug in the `tower::ready_cache`
module, tower-rs/tower#415. The `ready_cache` module is used internally
in Tower's load balancer. This bug resulted in panics in the proxy
(linkerd/linkerd2#8666, linkerd/linkerd2#6086) in cases where the
Destination service sends a very large number of service discovery
updates (see linkerd/linkerd2#8677).

This commit updates the proxy's dependency on `tower` to 0.4.13, to
ensure that this bugfix is picked up.

Fixes linkerd/linkerd2#8666
Fixes linkerd/linkerd2#6086

[v0.4.13]: https://github.com/tower-rs/tower/releases/tag/tower-0.4.13
hawkw added a commit that referenced this pull request Jun 30, 2022
Tower [v0.4.13] includes a fix for a bug in the `tower::ready_cache`
module, tower-rs/tower#415. The `ready_cache` module is used internally
in Tower's load balancer. This bug resulted in panics in the proxy
(linkerd/linkerd2#8666, linkerd/linkerd2#6086) in cases where the
Destination service sends a very large number of service discovery
updates (see linkerd/linkerd2#8677).

This commit updates the proxy's dependency on `tower` to 0.4.13, to
ensure that this bugfix is picked up.

Fixes linkerd/linkerd2#8666
Fixes linkerd/linkerd2#6086

[v0.4.13]: https://github.com/tower-rs/tower/releases/tag/tower-0.4.13
hawkw added a commit that referenced this pull request Jun 30, 2022
Tower [v0.4.13] includes a fix for a bug in the `tower::ready_cache`
module, tower-rs/tower#415. The `ready_cache` module is used internally
in Tower's load balancer. This bug resulted in panics in the proxy
(linkerd/linkerd2#8666, linkerd/linkerd2#6086) in cases where the
Destination service sends a very large number of service discovery
updates (see linkerd/linkerd2#8677).

This commit updates the proxy's dependency on `tower` to 0.4.13, to
ensure that this bugfix is picked up.

Fixes linkerd/linkerd2#8666
Fixes linkerd/linkerd2#6086

[v0.4.13]: https://github.com/tower-rs/tower/releases/tag/tower-0.4.13
hawkw added a commit that referenced this pull request Jun 30, 2022
Tower [v0.4.13] includes a fix for a bug in the `tower::ready_cache`
module, tower-rs/tower#415. The `ready_cache` module is used internally
in Tower's load balancer. This bug resulted in panics in the proxy
(linkerd/linkerd2#8666, linkerd/linkerd2#6086) in cases where the
Destination service sends a very large number of service discovery
updates (see linkerd/linkerd2#8677).

This commit updates the proxy's dependency on `tower` to 0.4.13, to
ensure that this bugfix is picked up.

Fixes linkerd/linkerd2#8666
Fixes linkerd/linkerd2#6086

[v0.4.13]: https://github.com/tower-rs/tower/releases/tag/tower-0.4.13
hawkw added a commit to linkerd/linkerd2 that referenced this pull request Jul 1, 2022
large number of service discovery updates, for incorrect handling of
`CONNECT` requests with `Content-Length` headers, and for a failure to
correctly resolve DNS SRV records for the control plane.

---

1817b3f3 update Tower to 0.4.13 to fix load balancer panic (linkerd/linkerd2-proxy#1758)
bc512765 dns: Fall back to A record when SRV resolution fails (linkerd/linkerd2-proxy#1670)
ac1039b0 http: Strip illegal headers from CONNECT responses (linkerd/linkerd2-proxy#1699)
ebcf7cbd Dedupe discovery updates (linkerd/linkerd2-proxy#1759)
hawkw added a commit to linkerd/linkerd2 that referenced this pull request Jul 1, 2022
This release cherry-picks commits from the `main` branch into the
`release/v2.161` branch, including fixes for a panic when processing a
large number of service discovery updates, for incorrect handling of
`CONNECT` requests with `Content-Length` headers, and for a failure to
correctly resolve DNS SRV records for the control plane.

---

1817b3f3 update Tower to 0.4.13 to fix load balancer panic (linkerd/linkerd2-proxy#1758)
bc512765 dns: Fall back to A record when SRV resolution fails (linkerd/linkerd2-proxy#1670)
ac1039b0 http: Strip illegal headers from CONNECT responses (linkerd/linkerd2-proxy#1699)
ebcf7cbd Dedupe discovery updates (linkerd/linkerd2-proxy#1759)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants