tracing: Simplify trace initialization (for #1642)#1688
Merged
olix0r merged 2 commits intoeliza/log-streaming-demofrom May 20, 2022
Merged
tracing: Simplify trace initialization (for #1642)#1688olix0r merged 2 commits intoeliza/log-streaming-demofrom
olix0r merged 2 commits intoeliza/log-streaming-demofrom
Conversation
While reviewing #1642, I found myself wanting clearer documentation about what is being initilalized. This change attempts to reorganize the builder for clarity. Signed-off-by: Oliver Gould <[email protected]>
hawkw
approved these changes
May 20, 2022
Contributor
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
yeah, this is definitely more readable, thanks!
Comment on lines
+67
to
+72
| filter: std::env::var(ENV_LOG_LEVEL) | ||
| .ok() | ||
| .unwrap_or_else(|| DEFAULT_LOG_LEVEL.to_string()), | ||
| format: std::env::var(ENV_LOG_FORMAT) | ||
| .ok() | ||
| .unwrap_or_else(|| DEFAULT_LOG_FORMAT.to_string()), |
Co-authored-by: Eliza Weisman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #1642, I found myself wanting clearer documentation
about what is being initilalized. This change attempts to reorganize the
builder for clarity.
Signed-off-by: Oliver Gould [email protected]