fix uses of Instant::sub#1457
Merged
olix0r merged 2 commits intover/saturating_duration_sincefrom Feb 1, 2022
Merged
Conversation
It looks like clippy's disallowed methods can't detect the use of disallowed *operators*, so #1456 misses a bunch of uses of the `-` operator on `Instant`s, mostly in metrics, tap, and the log timestamp formatter. This fixes all of them that I could find.
hawkw
commented
Feb 1, 2022
Contributor
Author
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
i missed that a couple of those were actually <Instant> - <Duration> instead, which broke when changed to saturating_duration_since (and, the non-saturating subs were legit in that case since the Duration is not going to time travel)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like clippy's disallowed methods can't detect the use of
disallowed operators, so #1456 misses a bunch of uses of the
-operator on
Instants, mostly in metrics, tap, and the log timestampformatter.
This fixes all of them that I could find.