Conversation
The coverage workflow is misconfigured so that it fails to run: `cargo-tarpaulin` has command line arguments that don't match other cargo commands (`--packages` instead of `--package`, which cannot be mixed with `--workspace`). Furthermore, it doesn't seem that we actually benefit from running tarpaulin over our non-integration tests, since the coverage reports are not merged.
hawkw
approved these changes
Nov 30, 2021
Contributor
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
looks good to me! i did notice that there is a mechanism for running Tarpaulin with multiple feature sets, so it might be worth investigating that in a follow-up?
Comment on lines
+34
to
+39
| # XXX(ver) AFAICT, Tarpaulin doesn't allow us to compose a report over multiple invocations, | ||
| # so we have to choose between getting coverage from unit tests and integration tests (since | ||
| # integration tests require --no-default-features to avoid flakiness). Currently the | ||
| # integration tests seem to cover more code, so we skip the unit tests for now :(. | ||
| #- run: cargo tarpaulin --locked --workspace --exclude=linkerd2-proxy --exclude=linkerd-app-integration --no-run | ||
| #- run: cargo tarpaulin --locked --workspace --exclude=linkerd2-proxy --exclude=linkerd-app-integration --skip-clean --ignore-tests --no-fail-fast --out=Xml |
Contributor
There was a problem hiding this comment.
hmm, that's kind of a bummer. Looking at the docs it looks like we might be able to define different configurations (with different featuresets) in Tarpaulin's config file, I wonder if we could use that instead of separate runs?
Member
Author
There was a problem hiding this comment.
Cool! If you can help figure that out, would be happy to use it :)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Dec 22, 2021
This release updates dependencies. --- * build(deps): bump serde_json from 1.0.71 to 1.0.72 (linkerd/linkerd2-proxy#1389) * build(deps): bump tracing-subscriber from 0.3.2 to 0.3.3 (linkerd/linkerd2-proxy#1391) * ci: Skip unit tests in coverage report (linkerd/linkerd2-proxy#1390) * build(deps): bump libc from 0.2.108 to 0.2.109 (linkerd/linkerd2-proxy#1395) * build(deps): bump EmbarkStudios/cargo-deny-action from 1.2.6 to 1.2.9 (linkerd/linkerd2-proxy#1394) * Fixes for compiling on macOS (linkerd/linkerd2-proxy#1392) * Remove macOS-specific transport label tests (linkerd/linkerd2-proxy#1396) * build(deps): bump actions/download-artifact from 2.0.10 to 2.1.0 (linkerd/linkerd2-proxy#1398) * build(deps): bump actions/upload-artifact from 2.2.4 to 2.3.0 (linkerd/linkerd2-proxy#1397) * build(deps): bump h2 from 0.3.7 to 0.3.8 (linkerd/linkerd2-proxy#1401) * build(deps): bump tonic-build from 0.6.0 to 0.6.2 (linkerd/linkerd2-proxy#1399) * build(deps): bump tonic from 0.6.1 to 0.6.2 (linkerd/linkerd2-proxy#1400) * build(deps): bump h2 from 0.3.8 to 0.3.9 (linkerd/linkerd2-proxy#1405) * build(deps): bump hyper from 0.14.15 to 0.14.16 (linkerd/linkerd2-proxy#1404) * build(deps): bump libc from 0.2.109 to 0.2.110 (linkerd/linkerd2-proxy#1403) * build(deps): bump async-trait from 0.1.51 to 0.1.52 (linkerd/linkerd2-proxy#1402) * build(deps): bump tokio from 1.14.0 to 1.15.0 (linkerd/linkerd2-proxy#1410) * inbound: Simplify GatewayIo type (linkerd/linkerd2-proxy#1414) * build(deps): bump actions/upload-artifact from 2.3.0 to 2.3.1 (linkerd/linkerd2-proxy#1409) * build(deps): bump boring from 1.1.6 to 2.0.0 (linkerd/linkerd2-proxy#1413) * build(deps): bump tokio-rustls from 0.23.1 to 0.23.2 (linkerd/linkerd2-proxy#1412) * build(deps): bump libc from 0.2.110 to 0.2.112 (linkerd/linkerd2-proxy#1408) * build(deps): bump futures from 0.3.18 to 0.3.19 (linkerd/linkerd2-proxy#1415) * build(deps): bump serde_json from 1.0.72 to 1.0.73 (linkerd/linkerd2-proxy#1407) * build(deps): bump num_cpus from 1.13.0 to 1.13.1 (linkerd/linkerd2-proxy#1418) * build(deps): bump linkerd2-proxy-api from 0.3.0 to 0.3.1 (linkerd/linkerd2-proxy#1419)
alpeb
pushed a commit
to linkerd/linkerd2
that referenced
this pull request
Dec 22, 2021
This release updates dependencies. --- * build(deps): bump serde_json from 1.0.71 to 1.0.72 (linkerd/linkerd2-proxy#1389) * build(deps): bump tracing-subscriber from 0.3.2 to 0.3.3 (linkerd/linkerd2-proxy#1391) * ci: Skip unit tests in coverage report (linkerd/linkerd2-proxy#1390) * build(deps): bump libc from 0.2.108 to 0.2.109 (linkerd/linkerd2-proxy#1395) * build(deps): bump EmbarkStudios/cargo-deny-action from 1.2.6 to 1.2.9 (linkerd/linkerd2-proxy#1394) * Fixes for compiling on macOS (linkerd/linkerd2-proxy#1392) * Remove macOS-specific transport label tests (linkerd/linkerd2-proxy#1396) * build(deps): bump actions/download-artifact from 2.0.10 to 2.1.0 (linkerd/linkerd2-proxy#1398) * build(deps): bump actions/upload-artifact from 2.2.4 to 2.3.0 (linkerd/linkerd2-proxy#1397) * build(deps): bump h2 from 0.3.7 to 0.3.8 (linkerd/linkerd2-proxy#1401) * build(deps): bump tonic-build from 0.6.0 to 0.6.2 (linkerd/linkerd2-proxy#1399) * build(deps): bump tonic from 0.6.1 to 0.6.2 (linkerd/linkerd2-proxy#1400) * build(deps): bump h2 from 0.3.8 to 0.3.9 (linkerd/linkerd2-proxy#1405) * build(deps): bump hyper from 0.14.15 to 0.14.16 (linkerd/linkerd2-proxy#1404) * build(deps): bump libc from 0.2.109 to 0.2.110 (linkerd/linkerd2-proxy#1403) * build(deps): bump async-trait from 0.1.51 to 0.1.52 (linkerd/linkerd2-proxy#1402) * build(deps): bump tokio from 1.14.0 to 1.15.0 (linkerd/linkerd2-proxy#1410) * inbound: Simplify GatewayIo type (linkerd/linkerd2-proxy#1414) * build(deps): bump actions/upload-artifact from 2.3.0 to 2.3.1 (linkerd/linkerd2-proxy#1409) * build(deps): bump boring from 1.1.6 to 2.0.0 (linkerd/linkerd2-proxy#1413) * build(deps): bump tokio-rustls from 0.23.1 to 0.23.2 (linkerd/linkerd2-proxy#1412) * build(deps): bump libc from 0.2.110 to 0.2.112 (linkerd/linkerd2-proxy#1408) * build(deps): bump futures from 0.3.18 to 0.3.19 (linkerd/linkerd2-proxy#1415) * build(deps): bump serde_json from 1.0.72 to 1.0.73 (linkerd/linkerd2-proxy#1407) * build(deps): bump num_cpus from 1.13.0 to 1.13.1 (linkerd/linkerd2-proxy#1418) * build(deps): bump linkerd2-proxy-api from 0.3.0 to 0.3.1 (linkerd/linkerd2-proxy#1419)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coverage workflow is misconfigured so that it fails to run:
cargo-tarpaulinhas command line arguments that don't match othercargo commands (
--packagesinstead of--package, which cannot bemixed with
--workspace). Furthermore, it doesn't seem that we actuallybenefit from running tarpaulin over our non-integration tests, since the
coverage reports are not merged.