Skip to content

Update all tower pieces to use Service<Request>#132

Merged
olix0r merged 2 commits intomasterfrom
svc-up
Nov 16, 2018
Merged

Update all tower pieces to use Service<Request>#132
olix0r merged 2 commits intomasterfrom
svc-up

Conversation

@seanmonstar
Copy link
Contributor

No description provided.

@seanmonstar seanmonstar requested a review from olix0r November 16, 2018 00:40
@hawkw
Copy link
Contributor

hawkw commented Nov 16, 2018

It looks like CI is failing because lib/router hasn't been updated?

@seanmonstar
Copy link
Contributor Author

Weird... Is it even used in the proxy? The proxy builds...

Copy link
Member

@olix0r olix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 😷

@seanmonstar
Copy link
Contributor Author

I've restarted CI several times now, seems intent on exploding due to disk space...

@olix0r olix0r merged commit f37c9e5 into master Nov 16, 2018
@olix0r olix0r deleted the svc-up branch November 16, 2018 19:19
sprt pushed a commit to sprt/linkerd2-proxy that referenced this pull request Aug 30, 2019
See linkerd#132. This PR adds a protocol field to the ClientTransport and ServerTransport messages, and modifies the proxy to report a value for this field (currently, it's only ever HTTP).

Currently, HTTP/1 and HTTP/2 are collapsed into one Protocol variant, see linkerd#132 (comment). I expect that we can treat H1 as a subset of H2 as far as metrics goes.

Note that after discussing it with @klingerf, I learned that the control plane telemetry API currently does not do anything with the ClientTransport and ServerTransport messages, so beyond regenerating the protobuf-generated code, no controller changes were actually necessary. As we actually add metrics to TCP transports, we'll want to make some additions to the telemetry API to ingest these metrics. If any metrics are shared between HTTP and raw TCP transports (say, bytes sent), we'll want to differentiate between them in Prometheus. All the metrics that the control plane currently ingests from telemetry reports are likely to be HTTP-specific (requests, responses, response latencies), or at least, do not apply to raw TCP.

Actually adding metrics to raw TCP transports will probably have to wait until there are raw TCP transports implemented in the proxy...

Signed-off-by: Eliza Weisman <[email protected]>
sprt pushed a commit to sprt/linkerd2-proxy that referenced this pull request Aug 30, 2019
simulate-proxy sends HTTP example data.

Modify this test script to also send TCP example data.

Part of linkerd#132

Signed-off-by: Andrew Seigner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants