ingress: Restore original dst address routing#1016
Merged
Conversation
In f8cc918, we started requiring the `l5d-dst-override` header. As described in linkerd/linkerd2#6157, this breaks some ingress configurations, especially those that may route to out-of-cluster resources. This change restores original-dst-addr routing for requests that do not include the `l5d-dst-override` header. Internally, this change centralizes the `DST_OVERRIDE_HEADER` and related utilities to the ingress module, as no other modules should have to know anything about it.
hawkw
approved these changes
May 24, 2021
Contributor
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
overall, lgtm --- i commented on some nits mostly related to logging, but no real blockers!
Member
Author
|
@hawkw PTAL, moved some things around |
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
May 27, 2021
* Controller clients of components with more than one replica could fail to drive all connections to completion. This could result in timeouts showing up in logs, but would not have prevented proxies from communicating with controllers. #6146 * linkerd/linkerd2-proxy#992 made the `l5d-dst-override` header required for ingress-mode proxies. This behavior has been reverted so that requests without this header are forwarded to their original destination. * OpenCensus trace spans for HTTP requests no longer include query parameters. --- * ci: Update/pin action dependencies (linkerd/linkerd2-proxy#1012) * control: Ensure endpoints are driven to readiness (linkerd/linkerd2-proxy#1014) * Make span name without query string (linkerd/linkerd2-proxy#1013) * ingress: Restore original dst address routing (linkerd/linkerd2-proxy#1016) * ci: Restict permissions in Actions (linkerd/linkerd2-proxy#1019) * Forbid unsafe code in most module (linkerd/linkerd2-proxy#1018)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
May 27, 2021
* Controller clients of components with more than one replica could fail to drive all connections to completion. This could result in timeouts showing up in logs, but would not have prevented proxies from communicating with controllers. #6146 * linkerd/linkerd2-proxy#992 made the `l5d-dst-override` header required for ingress-mode proxies. This behavior has been reverted so that requests without this header are forwarded to their original destination. * OpenCensus trace spans for HTTP requests no longer include query parameters. --- * ci: Update/pin action dependencies (linkerd/linkerd2-proxy#1012) * control: Ensure endpoints are driven to readiness (linkerd/linkerd2-proxy#1014) * Make span name without query string (linkerd/linkerd2-proxy#1013) * ingress: Restore original dst address routing (linkerd/linkerd2-proxy#1016) * ci: Restict permissions in Actions (linkerd/linkerd2-proxy#1019) * Forbid unsafe code in most module (linkerd/linkerd2-proxy#1018)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In f8cc918, we started requiring the
l5d-dst-overrideheader. Asdescribed in linkerd/linkerd2#6157, this breaks some ingress
configurations, especially those that may route to out-of-cluster
resources.
This change restores original-dst-addr routing for requests that do not
include the
l5d-dst-overrideheader.Internally, this change centralizes the
DST_OVERRIDE_HEADERandrelated utilities to the ingress module, as no other modules should have
to know anything about it.