tests: manually inject external-prometheus#6649
Merged
Pothulapati merged 1 commit intomainfrom Aug 12, 2021
Merged
Conversation
Looked at the CI failures after #6627 was merged, and in all the cases the external prometheus pod wasn't injected. This updates the `external-prometheus-deep` test to manually inject the `external-prometheus` deployment instead of having the injection be nondeterministic. Signed-off-by: Tarun Pothulapati <[email protected]>
alpeb
approved these changes
Aug 11, 2021
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
This is cool. It'd be better to figure what's the race causing this, but getting rid of the flakiness once and for all is more important 👍
adleong
approved these changes
Aug 11, 2021
olix0r
approved these changes
Aug 12, 2021
sannimichaelse
pushed a commit
to sannimichaelse/linkerd2
that referenced
this pull request
Aug 13, 2021
Looked at the CI failures after linkerd#6627 was merged, and in all the cases the external prometheus pod wasn't injected. This updates the `external-prometheus-deep` test to manually inject the `external-prometheus` deployment instead of having the injection be nondeterministic. Signed-off-by: Tarun Pothulapati <[email protected]> Signed-off-by: Sanni Michael <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looked at the CI failures after #6627
was merged, and in all the cases the external prometheus pod
wasn't injected.
This updates the
external-prometheus-deeptest to manuallyinject the
external-prometheusdeployment instead of havingthe injection be nondeterministic.
Signed-off-by: Tarun Pothulapati [email protected]