Merged
Conversation
* Controller clients of components with more than one replica could fail to drive all connections to completion. This could result in timeouts showing up in logs, but would not have prevented proxies from communicating with controllers. #6146 * linkerd/linkerd2-proxy#992 made the `l5d-dst-override` header required for ingress-mode proxies. This behavior has been reverted so that requests without this header are forwarded to their original destination. * OpenCensus trace spans for HTTP requests no longer include query parameters. --- * ci: Update/pin action dependencies (linkerd/linkerd2-proxy#1012) * control: Ensure endpoints are driven to readiness (linkerd/linkerd2-proxy#1014) * Make span name without query string (linkerd/linkerd2-proxy#1013) * ingress: Restore original dst address routing (linkerd/linkerd2-proxy#1016) * ci: Restict permissions in Actions (linkerd/linkerd2-proxy#1019) * Forbid unsafe code in most module (linkerd/linkerd2-proxy#1018)
Member
Author
|
The multicluster test keeps stalling in CI. It passes locally, though it's surprisingly slow: It takes ~2.5 minutes for each install (which occur serially, so ~5 mins total) and there's about 3 minutes spent doing cluster setup, mostly loading images (most of which don't appear used by these tests -- tap, grafana, etc). In CI a single install_test takes significantly longer: which makes it virtually impossible for this test to complete in under 10 minutes (which appears to be a timeout we're hitting): While we probably need to increase these timeouts in the short-term, we probably need to invest in reducing unnecessary overhead in our tests... |
Pothulapati
approved these changes
May 27, 2021
Contributor
Pothulapati
left a comment
Pothulapati
left a comment
There was a problem hiding this comment.
LGTM! 
(looking forward for the tests to pass)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to drive all connections to completion. This could result in timeouts
showing up in logs, but would not have prevented proxies from
communicating with controllers. Outbound proxy delays writing of TLS handshake message #6146
l5d-dst-overrideheader requiredfor ingress-mode proxies. This behavior has been reverted so that
requests without this header are forwarded to their original
destination.
parameters.