Skip to content

Fix proxy-identity log line and print identity in destination client#4873

Merged
kleimkuhler merged 1 commit intomainfrom
kleimkuhler/proxy-identity-fixes
Aug 13, 2020
Merged

Fix proxy-identity log line and print identity in destination client#4873
kleimkuhler merged 1 commit intomainfrom
kleimkuhler/proxy-identity-fixes

Conversation

@kleimkuhler
Copy link
Contributor

@kleimkuhler kleimkuhler commented Aug 12, 2020

Motivation

These changes came up when testing mock identity. I found it useful for the
destination client to print the identity of endpoints.

❯ go run controller/script/destination-client/main.go -method get -path h1.test.example.com:8080
INFO[0000] Add:                                         
INFO[0000] labels: map[concrete:h1.test.example.com:8080] 
INFO[0000] - 127.0.0.1:4143                             
INFO[0000]   - labels: map[addr:127.0.0.1:4143 h2:false] 
INFO[0000]   - protocol hint: UNKNOWN                   
INFO[0000]   - identity: dns_like_identity:{name:"foo.ns1.serviceaccount.identity.linkerd.cluster.local"} 
INFO[0000]

I also fixed a log line in the proxy-identity where used the wrong value for the
CSR path

Signed-off-by: Kevin Leimkuhler [email protected]

@kleimkuhler kleimkuhler requested a review from a team as a code owner August 12, 2020 23:43
adleong
adleong approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥤

@kleimkuhler kleimkuhler merged commit 525ad26 into main Aug 13, 2020
@kleimkuhler kleimkuhler deleted the kleimkuhler/proxy-identity-fixes branch August 13, 2020 20:49
@kleimkuhler kleimkuhler mentioned this pull request Aug 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alpeb alpeb alpeb approved these changes

@adleong adleong adleong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kleimkuhler @alpeb @adleong