Conversation
alpeb
reviewed
Jul 2, 2020
CHANGES.md
Outdated
|
|
||
| * Add better messaging during scheduling errors on retry for HA installations | ||
| * Add option to persist prometheus data (thanks @naseemkullah!) | ||
| * Upgrades generated protobuf files to v1.4.2 |
Member
There was a problem hiding this comment.
Not user-facing, so we can leave this one out
Member
Contributor
Contributor
|
One last merge before I sign off! #4653 |
adleong
reviewed
Jul 2, 2020
CHANGES.md
Outdated
| adds a feature to persist prometheus data as an option to storing the data in | ||
| memory, and upgrades the protobuf version to v1.4.2 | ||
|
|
||
| * Add better messaging during scheduling errors on retry for HA installations |
Member
There was a problem hiding this comment.
"messaging" feels overly vague. This is about linkerd check output, right?
CHANGES.md
Outdated
| ## edge-20.7.1 | ||
|
|
||
| This edge release improves messaging for retries when pods are unschedulable, | ||
| adds a feature to persist prometheus data as an option to storing the data in |
Member
There was a problem hiding this comment.
"as an option" reads a bit strangely to me. did you mean "as an alternative"?
I'd word this more along the lines of: "added the option to use a persistent volume for Prometheus data, allowing data to persist across restarts"
CHANGES.md
Outdated
|
|
||
| * Add better messaging during scheduling errors on retry for HA installations | ||
| * Add option to persist prometheus data (thanks @naseemkullah!) | ||
| * Upgrades generated protobuf files to v1.4.2 |
Signed-off-by: Charles Pretzer <[email protected]>
Signed-off-by: Charles Pretzer <[email protected]>
Signed-off-by: Charles Pretzer <[email protected]>
cpretzer
force-pushed
the
cpretzer/edge-20.7.1
branch
from
2675958 to
32f76de
Compare
olix0r
reviewed
Jul 2, 2020
CHANGES.md
Outdated
Comment on lines
11
to
21
| * Controller | ||
| * Adds better messaging during scheduling errors on retry for HA installations | ||
| * CLI | ||
| * Adds option to persist prometheus data (thanks @naseemkullah!) | ||
| * Adds support for passing a URL to the `--addon-config` flag, so you can now | ||
| use a file or an URL for installing add ons | ||
| * Helm | ||
| * Fixes a bug in the CNI helm chart by correcting a helm value field name | ||
| * Proxy | ||
| * Improves tail latencies by increasing the default buffer size to reduce | ||
| contention in high-concurrency situations |
Member
There was a problem hiding this comment.
Suggested change
| * Controller | |
| * Adds better messaging during scheduling errors on retry for HA installations | |
| * CLI | |
| * Adds option to persist prometheus data (thanks @naseemkullah!) | |
| * Adds support for passing a URL to the `--addon-config` flag, so you can now | |
| use a file or an URL for installing add ons | |
| * Helm | |
| * Fixes a bug in the CNI helm chart by correcting a helm value field name | |
| * Proxy | |
| * Improves tail latencies by increasing the default buffer size to reduce | |
| contention in high-concurrency situations | |
| * Some commands like `linkerd stat` would fail would fail if any control plane components were unhealthy, even when other replicas are healthy. This checks have been relaxed. | |
| * The helm chart can now configure persistent storage for Prometheus (thanks @naseemkullah!) | |
| * `linkerd install --addon-config=` now supports URLs in addition to local files | |
| * The CNI Helm chart used the incorrect variable to determine the container version. This is now controlled by `cniPluginVersion`. | |
| * The proxy's default buffer sized has been increased, which reduces latency when the proxy has many concurrent clients. |
Signed-off-by: Charles Pretzer <[email protected]>
olix0r
approved these changes
Jul 2, 2020
CHANGES.md
Outdated
| conditions for CLI commands, a fix to correctly resolve the CNI image version | ||
| when using helm, support for using URLs with add-ons, proxy improvements under | ||
| concurrency, and functionality to configure the proxy log format by annotation | ||
| or in the helm chart. |
Member
There was a problem hiding this comment.
This whole thing feels redundant to me. I'd just omit it (if there's nothing particularly notable about the edge).
Signed-off-by: Charles Pretzer <[email protected]>
Pothulapati
approved these changes
Jul 3, 2020
CHANGES.md
Outdated
| (thanks again @naseemkullah!) | ||
| * `linkerd install --addon-config=` now supports URLs in addition to local | ||
| files | ||
| * The CNI Helm chart used the incorrect variable name to determine the image |
Contributor
There was a problem hiding this comment.
not to determine the image tag but for the createdBy version tag
Contributor
There was a problem hiding this comment.
blame is on me for not writing useful pr merge commit message
Signed-off-by: Charles Pretzer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
CHANGES.mdwith release notes foredge-20.7.1Signed-off-by: Charles Pretzer [email protected]