Use add-on level values.yaml for chart generation#4682
Merged
Pothulapati merged 1 commit intomainfrom Jul 2, 2020
Merged
Conversation
This change adds add-on level values.yaml into the template to use for rendering. Signed-off-by: Tarun Pothulapati <[email protected]>
Contributor
Author
|
Yep @alpeb, Was planning to separate this change. So, that the PR can focus only moving prometheus into a sub-chart. |
This was referenced Jul 2, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4572
We have been planning to move defaults into add-on specific
values.yaml.This change adds add-on level
values.yamlto be part of the helm template to be used forrendering.
As there are values specified in
add-onlevelvalues.yaml, there are no changes needed for golden test files.This PR will have follow up PR's which move defaults into
values.yamlforgrafanaandtracingcharts.Signed-off-by: Tarun Pothulapati [email protected]