Skip to content

Upgrade generated protobuf files to v1.4.2#4673

Merged
alpeb merged 1 commit intomainfrom
alpeb/protobuf-1.4.2
Jun 26, 2020
Merged

Upgrade generated protobuf files to v1.4.2#4673
alpeb merged 1 commit intomainfrom
alpeb/protobuf-1.4.2

Conversation

@alpeb
Copy link
Member

@alpeb alpeb commented Jun 25, 2020

Regenerated protobuf files, using version 1.4.2 that was upgraded from
1.3.2 with the proxy-api update in #4614.

As of v1.4 protobuf messages are disallowed to be copied (because they
hold a mutex), so whenever a message is passed to or returned from a
function we need to use a pointer.

This affects mostly test files.

This is required to unblock #4620 which is adding a field to the config
protobuf.

Regenerated protobuf files, using version 1.4.2 that was upgraded from
1.3.2 with the proxy-api update in #4614.

As of v1.4 protobuf messages are disallowed to be copied (because they
hold a mutex), so whenever a message is passed to or returned from a
function we need to use a pointer.

This affects _mostly_ test files.

This is required to unblock #4620 which is adding a field to the config
protobuf.
@alpeb alpeb requested a review from a team as a code owner June 25, 2020 21:30
@alpeb alpeb changed the title Upgrade genereated protobuf files to v1.4.2 Upgrade generated protobuf files to v1.4.2 Jun 25, 2020
Copy link
Member

@zaharidichev zaharidichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kleimkuhler kleimkuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alpeb alpeb merged commit aea541d into main Jun 26, 2020
@alpeb alpeb deleted the alpeb/protobuf-1.4.2 branch June 26, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants