Update release workflow kind_integration job#4668
Merged
kleimkuhler merged 1 commit intomainfrom Jun 25, 2020
Merged
Conversation
Signed-off-by: Kevin Leimkuhler <[email protected]>
Pothulapati
approved these changes
Jun 25, 2020
Contributor
Pothulapati
left a comment
Pothulapati
left a comment
There was a problem hiding this comment.
LGTM and they look similar now :)
cpretzer
approved these changes
Jun 25, 2020
Contributor
cpretzer
left a comment
cpretzer
left a comment
There was a problem hiding this comment.
Great job of being thorough and consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed here, the
kind_integrationjob of the release workflow was not kept in sync with the changes made in #4593.Until GitHub actions can reuse yaml for separate workflows, these sections are supposed to be kept in sync.
This would be an issue if we had tried doing a release since #4593 merged, but that has not happened yet.
Changes
This updates the release workflow
kind_integrationjob to use the use new test interface, mainly removing cluster creation and image loading as necessary prerequisites.