Merged
Conversation
Signed-off-by: Kevin Leimkuhler <[email protected]>
alpeb
approved these changes
Jun 17, 2020
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
Test script: [install_test.go] Params: [--linkerd-namespace=l5d-integration-helm --helm-path=/home/runner/work/linkerd2/linkerd2/bin/helm --helm-chart=/home/runner/work/linkerd2/linkerd2/charts/linkerd2 --helm-stable-chart=linkerd/linkerd2 --helm-release=l5d-integration-test --upgrade-helm-from-version=stable-2.8.0]
LGTM 👍
Signed-off-by: Kevin Leimkuhler <[email protected]>
Signed-off-by: Kevin Leimkuhler <[email protected]>
Signed-off-by: Kevin Leimkuhler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#4557 changed the name of the function that
helm_upgrade_integration_testsuses.
install_stable()was renamed tolatest_release_channel()and now takes anargument for specifying either
edgeorstable.run_helm_upgrade_testis a function used by the helm upgrade integration testand was not properly updated to use
latest_release_channel().This silently passed integration tests because
run_helm_upgrade_teststartedpassing an empty string for the version to upgrade from, which results in the
default behavior of
install_test.go--and therefore still passes.Solution
run_helm_upgrade_testnow useslatest_release_channel()and passes theproper argument.
Additionally, it checks that the version returned from
latest_release_channel()is not empty. If it is empty, it exits the test. Thisensures something like this does happen in the future.
Signed-off-by: Kevin Leimkuhler [email protected]