Merged
Conversation
Signed-off-by: Tarun Pothulapati <[email protected]>
alpeb
approved these changes
Jun 8, 2020
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
LGTM 👍
Do you mind opening an issue to track the effort/investigation for stop building the grafana image?
Contributor
Author
|
Raised #4572 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4556
Currently, whenever we perform upgrades, the configuration from
linkerd-config-addonsis used and overrides the default upgrades. This prevents grafana image tag from being upgraded, whengrafana.image.versionis present inlinkerd-config-addonsThe fix is to remove
grafana.image.versionfield, so that users we don't use the value fromlinkerd-config-addons(which prevents us to upgrade to the latest image).This means that, users who want to get their own Grafana Image should have the image tagged with the control-plane version.
This does not effect the bring your own Grafana image use-case.
Future Concrete Solution:
Signed-off-by: Tarun Pothulapati [email protected]