Added missing annotations to addon test fixtures#4286
Merged
Conversation
alpeb
force-pushed
the
alpeb/addons-golden-missing-ns
branch
from
9218415 to
dd4863b
Compare
adleong
approved these changes
Apr 23, 2020
kleimkuhler
approved these changes
Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #4271
Add missing annotation
linkerd.io/workload-ns: linkerdin in theaddons test fixtures, introduced by the downward work from #4199
CI for #4271 didn't catch the problem because that PR went green before #4199 was merged.