Add MeshedPodCount field to TS resource rows#4273
Merged
kleimkuhler merged 4 commits intomasterfrom Apr 21, 2020
Merged
Conversation
Signed-off-by: Kevin Leimkuhler <[email protected]>
Signed-off-by: Kevin Leimkuhler <[email protected]>
Signed-off-by: Kevin Leimkuhler <[email protected]>
1ad0ea1 to
3f84bdf
Compare
kleimkuhler
commented
Apr 18, 2020
Contributor
Author
|
The other solution for this is that These resources are unmeshed, so it's another reasonable solution. I chose to do use |
Signed-off-by: Kevin Leimkuhler <[email protected]>
adleong
approved these changes
Apr 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of the
--unmeshedflag changed the rendering behavior of thestatcommand so that resources with 0 meshed pods are not displayed bydefault.
Rendering is based off the row's
MeshedPodCountfield which is currently notset by
func trafficSplitResourceQuery. This change sets that field now sothat in rendering, the trafficsplit resource is rendered in the output.
The reason for this not showing up in testing is addressed by #4272 where the
statcommand behavior for no traffic is changed.The following now works without
--unmeshedflag being passed: