Skip to content

Use /live for liveness probe#4270

Merged
adleong merged 3 commits intomasterfrom
alex/its-alive
Apr 17, 2020
Merged

Use /live for liveness probe#4270
adleong merged 3 commits intomasterfrom
alex/its-alive

Conversation

@adleong
Copy link
Member

@adleong adleong commented Apr 16, 2020

Fixes #3984

We use the new /live admin endpoint in the Linkerd proxy for liveness probes instead of the /metrics endpoint. This endpoint returns a much smaller payload.

Signed-off-by: Alex Leong [email protected]

Signed-off-by: Alex Leong <[email protected]>
@adleong adleong requested a review from kleimkuhler as a code owner April 16, 2020 23:08
Signed-off-by: Alex Leong <[email protected]>
Copy link
Contributor

@kleimkuhler kleimkuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adleong adleong merged commit 5d3862c into master Apr 17, 2020
@adleong adleong deleted the alex/its-alive branch April 17, 2020 21:53
@kleimkuhler
Copy link
Contributor

It looks like some additional golden files needed to be updated. They are covered #4273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop using the proxy's /metrics endpoint as a livenessProbe

4 participants