Add rolling update strategy to for HA deployments#4267
Merged
kleimkuhler merged 1 commit intomasterfrom Apr 16, 2020
Merged
Conversation
Signed-off-by: Kevin Leimkuhler <[email protected]>
Contributor
Author
|
Relates to #3939 |
Contributor
|
hmmm, Looks like some Definitely not a problem, but wondering how GH checks missed them. 🤔 |
Member
|
@Pothulapati Turns out the test is failing but it's not surfacing as a suite failure by |
alpeb
added a commit
that referenced
this pull request
Apr 17, 2020
`linkerd stat` was doing an early `os.Exit(0)` when no traffic was found, which avoided `go test` to report any test failure that ended in that code path. This was hiding a mismatch in the golden files for HA after the introduction of the rolling update strategy (#4267), and the failure of `linkerd stat trafficsplit` not returning results unless `--unmeshed` is used. For the latter, I added the flag to the tests in order to temporarly pass them, but the underlying issue remains to be fixed in a separate PR.
alpeb
added a commit
that referenced
this pull request
Apr 21, 2020
* Some `linkerd stat` test failures were being hidden `linkerd stat` was doing an early `os.Exit(0)` when no traffic was found, which avoided `go test` to report any test failure that ended in that code path. This was hiding a mismatch in the golden files for HA after the introduction of the rolling update strategy (#4267), and the failure of `linkerd stat trafficsplit` not returning results unless `--unmeshed` is used. For the latter, I added the flag to the tests in order to temporarly pass them, but the underlying issue remains to be fixed in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a rolling update strategy to Linkerd deployments that have
three replicas during HA deployments. This allows for at most one pod to begin
terminating before a new pod ready is ready.
This allows for upgrades to take place on three node clusters. As a pod begins
terminating, it opens up the node for the new pod to start initializing.
.Values.enablePodAntiAffinitywas chosen as the conditional here because itis set by the
values-ha.yamlconfig on HA deployments