Upgrade yarn and add network-concurrency flag#3826
Merged
scottcarol merged 1 commit intomasterfrom Dec 14, 2019
Merged
Conversation
alpeb
approved these changes
Dec 13, 2019
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
Changes look good to me, and it tests well, thanks @scottcarol !
dadjeibaah
approved these changes
Dec 14, 2019
Contributor
dadjeibaah
left a comment
dadjeibaah
left a comment
There was a problem hiding this comment.
This change looks good to me. I was able to build it successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI runs are occasionally failing during the JS unit tests due to Yarn, with a “404 Not Found” for a specific package:
error An unexpected error occurred: "https://registry.yarnpkg.com/es-abstract/-/es-abstract-1.14.0.tgz: Request failed \"404 Not Found\””.This seems to be a widespread Yarn problem with many different packages (example).
This PR attempts to fix this with two main changes:
1.7.0to1.21.1(current stable version) in the Dockerfile and Github Actions workflow--network-concurrency 1flag, setting the maximum number of concurrent network requests to 1, which is suggested as a fix here — thanks @admcTo test the PR
Check out this branch and run
Note on this specific package: Ever since #3725 was merged in November, we are no longer using the subdependency
es-abstract 1.14.0anywhere. You can confirm this by looking in theyarn.lockfile for master (and the diff for #3725).